[vlc-devel] [PATCH] hotkeys: fullscreen state of the vout should have precedence over fullscreen state of the playlist

Felix Abecassis felix.abecassis at gmail.com
Mon Jan 27 16:26:42 CET 2014


2014-01-27 Rémi Denis-Courmont <remi at remlab.net>:
>
> That is not what the patch comments say. A correct patch is not just a correct
> diff, but also correct comments.
This was a description of the bug, double clicking does not trigger
this codepath since the commit you've reverted. For this reason
fullscreen state of the vout was set to 1 but fullscreen state of the
playlist was set to 0.
When pressing 'F' afterwards, we toggle the state of the playlist (to
1) and set the state of the vout to the same value. Thus we stay
fullscreen the first time we hit 'F'.

-- 
Félix Abecassis
http://felix.abecassis.me



More information about the vlc-devel mailing list