[vlc-devel] [PATCH] Direct3D: implement HLSL pixel shading in the rendering pipeline

Rémi Denis-Courmont remi at remlab.net
Tue Jan 28 11:44:02 CET 2014

On Tue, 28 Jan 2014 11:30:17 +0100, Rafaël Carré <funman at videolan.org>
> If the dll is absent the module would fail to load and we would waste
> less CPU.

That would require SetThreadErrorMode() in module_Load(), otherwise
Windows will show a critical error dialog. So the choices are:
1) ignore thread-safety issues surrounding SetErrorMode(),
2) rely on the main executable to call SetThreadError(), or
3) drop support for not only XP but also Vista...

Currently LibVLC does (1), which contradicts MSDN: "Because the error mode
is set for the entire process, you must ensure that multi-threaded
applications do not set different error-mode flags. Doing so can lead to
inconsistent error handling."

For VLC and the cache generator, we could switch to (2). But for external
LibVLC applications, there are really no good options.

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list