[vlc-devel] [PATCH] xcb: set the window position after mapping the window instead of during creation

Felix Abecassis felix.abecassis at gmail.com
Wed Jan 29 16:49:07 CET 2014


Thanks,

You are right, it would be better to have a way to know if the user
explicitly set the window position. However this change would impact
many vout modules since they would all need to check the value of
video-x/video-y against "-1" if we do it this way. I think the second
hunk of this patch should still be applied and we should create a new
ticket to implement the behaviour you've mentioned.

2014-01-29 Rémi Denis-Courmont <remi at remlab.net>:
> On Wed, 29 Jan 2014 12:59:00 +0100, Felix Abecassis
> <felix.abecassis at gmail.com> wrote:
>> 2014-01-29 Rémi Denis-Courmont <remi at remlab.net>:
>>>
>>> Problem is, we should only do that when the coordinate where explicitly
>>> requested. Otherwise, we should really let the WM decide on the window
>>> position, rather than force it to the top left.
>> We can have the default values of video-x and video-y set to "-1" to
>> signal the coordinates were not requested (like width/height). But how
>> do we let the WM set the window position? Coordinates are not optional
>> when creating the window.
>
> The X11 convention is to pass zero as the default value.
>
>
> --
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



-- 
Félix Abecassis
http://felix.abecassis.me



More information about the vlc-devel mailing list