[vlc-devel] smem: Use size_t for buffer sizes & fix warning
hugo at beauzee.fr
Wed Jan 29 18:32:48 CET 2014
On Wed, Jan 29, 2014 at 10:32 AM, Rafaël Carré <funman at videolan.org> wrote:
> On 01/28/14 23:42, Hugo Beauzée-Luyssen wrote:
>> On Wed, Jan 29, 2014 at 12:35 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>>> Debatable. What if another compiler version now complains that the value is
>>> assigned but never used?
>> Agreed for point 1 (including the part about strings). I guess I can
>> also update the wiki.
>> Point 2: it changes so little that I really don't care, up to the
>> reviewers. Does not warn on gcc4.8, didn't try clang.
> If you initialize it to i_height and reuse i_line in
> post_render_callback it will be alright
I'd argue that this is making the code less readable and is definitely
not worth doing for the sake of a (wrong) warning.
mail: hugo at beauzee.fr
More information about the vlc-devel