[vlc-devel] [PATCH] contrib/gpg-error: disable tests

[Rémi Denis-Courmont]

Le 2014-07-04 10:31, Rafaël Carré a écrit :
> Hello,
>
> On 07/04/14 00:48, Felix Paul Kühne wrote:
>> ---
>>  contrib/src/gpg-error/disable-tests.patch | 21 
>> +++++++++++++++++++++
>>  contrib/src/gpg-error/rules.mak           |  1 +
>>  2 files changed, 22 insertions(+)
>>  create mode 100644 contrib/src/gpg-error/disable-tests.patch
>>
>> diff --git a/contrib/src/gpg-error/disable-tests.patch 
>> b/contrib/src/gpg-error/disable-tests.patch
>> new file mode 100644
>> index 0000000..efcd79d
>> --- /dev/null
>> +++ b/contrib/src/gpg-error/disable-tests.patch
>> @@ -0,0 +1,21 @@
>> +diff -ru libgpg-error/Makefile.in libgpg-error-fixed/Makefile.in
>
> Please add autoreconf with a $(RECONF) call when you modify 
> Makefile.in

IIRC, it is the other way around: You MUST NOT run autoreconf (actually 
automake) if you modify Makefile.in, since it will get rewritten from 
Makefile.am, and the patch would be wasted.

If the project uses up-to-date automake syntax, it might be better to 
patch Makefile.am and indeed call $(RECONF) though.

-- 
Rémi Denis-Courmont