[vlc-devel] src/input: add a new input option flag to replace values of existing options (was: fix buffer underflow by avoiding inconsistent state in error case)

[David Fuhrmann]

Am 04.07.2014 um 21:49 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> Le vendredi 4 juillet 2014, 21:36:18 David Fuhrmann a écrit :
>> Hello Remi,
>> 
>> Am 04.07.2014 um 09:47 schrieb Rémi Denis-Courmont <remi at remlab.net>:
>>>  Hello,
>>> 
>>> Le 2014-07-04 00:52, David Fuhrmann a écrit :
>>>> Generally, _please_ complain to the specific patches or issues you
>>>> are having a problem with. Doing that in a totally unrelated thread,
>>>> and weeks or months afterwards ist not really helpful.
>>> 
>>> I cannot report issues before I find them (that would be two days ago on
>>> Trac).
>> Of course I have no problem if you find issues afterwards and after some
>> period of time. The more important point is that you should directly
>> answering to the appropriate mails (and to the right persons), instead if
>> misusing another dispute to express all your frustration you collected.
> 
> I don't know about you, but I don't keep an permanent archive of the mailing 
> list. And the public archives do not provide RFC2822 files for obvious antispam 
> reasons. So I cannot "answer" to old emails.

You can also create new mails with an appropriate right title. But I think you got my point.

>> Thus I think it was reasonable to believe that the patch is
>> fine, seeing the explanation and your lack of reaction, the approval from
>> others, and the ease and low risk of regressions.
> 
> Again, if someone says "Exactly", I assume they agree with me. Except you 
> obviously did not agree.

Yes, I was agreeing with the last part of your mail, but not with the first one. I think it is fair to assume that you read my complete mail.

> 
> There was no need to introduce a new flag, since the one existing flag is 
> mathematically enough to describe both possible intents: keep oldest (UNIQUE) 
> or replace with newest (zero).

I already told you that UNIQUE was not working at all. start-time=0 is not the same string as start-time=10.
And regardless of the flag, the action is not a replace, but an append to an existing array, which got bigger and bigger.

And this is completely aside from the fact that only the last option of all "start-time=xx“ variants was actually in effect.

Regards,
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140704/047b921a/attachment.html>