[vlc-devel] src/input: add a new input option flag to replace values of existing options (was: fix buffer underflow by avoiding inconsistent state in error case)

Rémi Denis-Courmont remi at remlab.net
Fri Jul 4 22:46:11 CEST 2014

Le vendredi 4 juillet 2014, 22:41:50 David Fuhrmann a écrit :
> Am 04.07.2014 um 22:32 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> > Le vendredi 4 juillet 2014, 22:00:32 David Fuhrmann a écrit :
> >> I already told you that UNIQUE was not working at all. start-time=0 is
> >> not
> >> the same string as start-time=10. And regardless of the flag, the action
> >> is
> >> not a replace, but an append to an existing array, which got bigger and
> >> bigger.
> > 
> > You were not making any sense and you still are not. There is no point
> > repeating for me to repeat the same thing over and over. That does not
> > mean I agree.
> Sorry, but _you_ are not making sense. Or maybe we are still
> misunderstanding each other. Please look at the code. INSERT_ELEM is
> clearly inserting an element into an array, not replacing an existing
> element.

I don't make sense? So there can be another sensible behaviour than keeping 
the oldest or the newest option value for a given item option. Well, I wonder 
what that third sane possibility would be.

Rémi Denis-Courmont

More information about the vlc-devel mailing list