[vlc-devel] VLCKit: half-baked ARC conversion

Florent Pillet fpillet at gmail.com
Sun Jul 6 17:44:49 CEST 2014


I was going to split & resubmit my latest patches, but then you committed a big patch for ARC conversion that changes a lot of code.

I'm all for it, but it is half baked. At some point you need to decide whether VLCKit is or isn't using ARC. Maintaining both is going to be tedious. With the current code base, turning on the ARC switch results in a bunch of compilation errors because the conversion is not complete.

On the other hand, some recent changes to VLCEventManager (the part that I have heavily fixed in my latest, not-yet-applied patch, and that is the cause of many issues under heavy use conditions) raise some compiler warnings due to the conversion of message_t from a struct to a class, and unspecified retain rules.

What is the status of this?
Are there more ARC-related upcoming patches to VLCKit I need to be aware of? 
And more importantly, is VLCKit moving to ARC now?

I can help with completing the transition to ARC, although my main goal right now is to reintegrate my VLCEventManager patches which are crucial to the stability of VLCKit.

Florent




More information about the vlc-devel mailing list