[vlc-devel] [PATCH] error.c: cover the case when newlocale fails and returns a null locale object

[Casian Andrei]

2014-07-07 18:02 GMT+03:00 Sean McGovern <gseanmcg at gmail.com>:

> Its not that the call is being interrupted (EINTR), is it?
>
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/newlocale.html
>
> When debugging, the errno variable does not change after newlocale() is
executed. It remains 2 (file not found, which is the reason
vlc_strerror_l() is called). What confuses me is that the documentation
states that on error it sets errno to indicate the cause of the error...

The function only fails when the locale name is empty, so there might be
some sort of configuration issue on my system.

But, the reason for this patch is that, in my opinion, it is not acceptable
for vlc to segfault when the newlocale() function happens to fail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140707/3f300e53/attachment.html>