[vlc-devel] [PATCH 3/5] VLCKit: migrate VLCMedia to ARC
nitz.carola at googlemail.com
Mon Jul 7 21:34:31 CEST 2014
great work. Thank you so much!
I just have a tiny remark
On 07 Jul 2014, at 20:47, Florent Pillet <fpillet at gmail.com> wrote:
> + at property (nonatomic, readwrite) VLCMediaState state;
> + at property (nonatomic, readwrite, strong) VLCTime *length;
> + at property (nonatomic, readwrite, strong) NSDictionary *metaDictionary;
strong and readwrite don’t need to be declared since they’re defaults but it doesn’t hurt.
NSDictionary properties just like NSString and NSArray should be declared with copy because of the mutable subclass.
> + at property (nonatomic, readwrite, strong) VLCMediaList * subitems;
> /* Statics */
More information about the vlc-devel