[vlc-devel] [PATCH 0/3] OMX: improve performance

Thomas Guillem guillem at archos.com
Thu Jul 10 16:29:55 CEST 2014


As discussed with Martin here:
https://github.com/tguillem/vlc/commit/7404e3065705107d5f87f63ed95c86cd16fe0633

I propose a set of 3 patches that should improve OMX performance.

With a Samsung Galaxy S3 and with HwBuffer activated (not in this set of
patches), I win a lot of FPS: from 1fps to 25fps.

The third patch is a bonus, only cosmetic, I don't know if you want it, but it
make the DecodeVideo function clearer:

...
    /* Take care of decoded frames first */
    if( DecodeVideoOutput( p_dec, &p_sys->out, &p_pic ) != 0 )
        goto error;

    if( DecodeVideoInput( p_dec, &p_sys->in, pp_block, &b_reconfig ) != 0 )
        goto error;

    /* If we don't have a p_pic from the first try. Try again */
    if( !b_reconfig && !p_pic &&
        DecodeVideoOutput( p_dec, &p_sys->out, &p_pic ) != 0 )
        goto error;
...

Regards,

Thomas Guillem (3):
  omxil: move output handling into DecodeVideoOutput
  omxil: improve performance
  omxil: move input handling into DecodeVideoInput

 modules/codec/omxil/omxil.c |  174 ++++++++++++++++++++++++++-----------------
 1 file changed, 105 insertions(+), 69 deletions(-)

-- 
1.7.10.4


-- 


This email and any files transmitted with it are confidential and are 
intended solely for the use of the individual or entity to which they are 
addressed. Access to this e-mail by anyone else is unauthorised. If you are 
not the intended recipient, any disclosure, copying, distribution or any 
action taken or omitted to be taken in reliance on it, is prohibited. 
E-mail messages are not necessarily secure. Archos does not accept 
responsibility for any changes made to this message after it was sent.



More information about the vlc-devel mailing list