[vlc-devel] [PATCH 5/9] VLCKit: There is no reason to have a blocking call to main thread from the event manager thread

Gleb Pinigin gpinigin at gmail.com
Fri Jul 11 04:08:12 CEST 2014


It's only needed to guarantee that events will be performed on main thread in dispatch order.

On Jul 11, 2014, at 6:35 AM, Florent Pillet <fpillet at gmail.com> wrote:

> If there is, it should be properly documented. Blocking calls are evil.
> ---
> Sources/VLCEventManager.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Sources/VLCEventManager.m b/Sources/VLCEventManager.m
> index 9b87bf4..31d11dd 100644
> --- a/Sources/VLCEventManager.m
> +++ b/Sources/VLCEventManager.m
> @@ -221,7 +221,7 @@ static void * EventDispatcherMainLoop(void * user_data)
>             else
>                 [self performSelectorOnMainThread:@selector(callObjectMethodWithArgs:)
>                                        withObject:message
> -                                    waitUntilDone: YES];
> +                                    waitUntilDone: NO];
>         }
> 
> 		/* Sleep a bit not to flood the interface */
> -- 
> 1.8.5.2 (Apple Git-48)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel




More information about the vlc-devel mailing list