[vlc-devel] [PATCH 3/3] omxil: move input handling into DecodeVideoInput
martin at martin.st
Fri Jul 11 07:54:18 CEST 2014
On Fri, 11 Jul 2014, Thomas Guillem wrote:
> OK, that should do it. "i_input_used" is passed recursively.
> But I think I just spotted a bug (not introduced by my patch, I hope ?).
> What happens if OMX_FIFO_GET_TIMEOUT does timeout the next time when
> i_input_used is != 0 ?
> I think DecodeVideo will return and will be called again but with the same
> p_block and with i_input_used = 0.
> I think we should use something like i_last_input_used in OmxPort struct, in
> order to save the p_block offset across several calls of DecodeVideo.
> I you agree, I'll propose an other patch.
Yes, this can probably happen - the current support for splitting a packet
over multiple buffers is mostly a quick hack. Your suggested solution
would probably be more robust.
More information about the vlc-devel