[vlc-devel] [PATCH 2/4] input: add a new variable storing which ES type was last modified

[Rémi Denis-Courmont]

Le 2014-07-21 17:56, Felix Abecassis a écrit :
> If this variable/callback mechanism is flawed, we need to find a
> better way for handling all events, not just this one. Maybe we could
> add a vlc_event_manager_t object to the input thread and safely pass
> events this way. This is what we do currently for input_item events.
> What do you think?

I am all for replacing the libvlccore event handling with something 
better. But I gave up on doing it myself because it was too deeply 
ingrained into some parts of the code. Also the libvlc event handler is 
more or less set in stone for ABI compatibility.

(...)
>> Again, it does not seem that "the" ES lock is taken on all code 
>> paths.
>>
>
> I think it is, so we should be fine. However the call graph of this
> module is a bit complex and indeed it is not specified explicitly 
> that
> the lock must be held to use the callback.

If you actually have checked (ouch), then add a comment where writing 
and reading the variables that they are only valid with the ES output 
lock.

-- 
Rémi Denis-Courmont