[vlc-devel] [PATCH 2/3] taglib: do not ignore mpeg ape tags

[Rémi Denis-Courmont]

Le mercredi 23 juillet 2014, 12:04:15 Anatoliy Anischovich a écrit :
> ---
>  modules/meta_engine/taglib.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/meta_engine/taglib.cpp b/modules/meta_engine/taglib.cpp
> index 1fa1b85..7039e86 100644
> --- a/modules/meta_engine/taglib.cpp
> +++ b/modules/meta_engine/taglib.cpp
> @@ -771,7 +771,7 @@ static int ReadMeta( vlc_object_t* p_this)
>      {
>          if( mpeg->ID3v2Tag() )
>              ReadMetaFromId3v2( mpeg->ID3v2Tag(), p_demux_meta, p_meta );
> -        else if( mpeg->APETag() )
> +        if( mpeg->APETag() )
>              ReadMetaFromAPE( mpeg->APETag(), p_demux_meta, p_meta );

I  note that this will override the ID3v2 tags with the APE ones. I have no 
informed opinion about which should of both have higher priority though.

>      }
>      else if( dynamic_cast<Ogg::File*>(f.file()) )
> @@ -1097,7 +1097,7 @@ static int WriteMeta( vlc_object_t *p_this )
>      {
>          if( mpeg->ID3v2Tag() )
>              WriteMetaToId3v2( mpeg->ID3v2Tag(), p_item );
> -        else if( mpeg->APETag() )
> +        if( mpeg->APETag() )
>              WriteMetaToAPE( mpeg->APETag(), p_item );

That chunk seems fine, but it does not really match with the patch description.

>      }
>      else if( dynamic_cast<Ogg::File*>(f.file()) )

-- 
Rémi Denis-Courmont
http://www.remlab.net/