[vlc-devel] [PATCH 2/2] nettle: fix library install path on Solaris

[Sean McGovern]

Hi Rafaël,

Nettle appears to be the only contrib so far that takes it upon itself to install to <destdir>/lib/64/ when building a 64-bit library on Solaris. Most other contribs would mandate an extra --libdir=<destdir>/lib/{amd64,sparcv9}, but this seems overkill since the VLC contribs collection is not actually intended for installation.

I would therefore prefer the first option of patching configure.ac, and I will send a patch shortly to do just that.

Thanks for the review,
Sean McG.
-----Original Message-----
From: Rafaël Carré <funman at videolan.org>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Wed, 23 Jul 2014 12:15:16 
To: Mailing list for VLC media player developers<vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH 2/2] nettle: fix library install path on
	Solaris

On 07/23/14 04:59, Sean McGovern wrote:
> ---
>  contrib/src/nettle/rules.mak |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/contrib/src/nettle/rules.mak b/contrib/src/nettle/rules.mak
> index 0da23d9..4af0f63 100644
> --- a/contrib/src/nettle/rules.mak
> +++ b/contrib/src/nettle/rules.mak
> @@ -15,6 +15,11 @@ $(TARBALLS)/nettle-$(NETTLE_VERSION).tar.gz:
>  nettle: nettle-$(NETTLE_VERSION).tar.gz .sum-nettle
>  	$(UNPACK)
>  	$(UPDATE_AUTOCONFIG)
> +ifdef HAVE_SOLARIS
> +ifeq ($(ARCH),x86_64)
> +	sed -i.orig -e 's,lib/64,lib,' nettle*/configure
> +endif
> +endif

To patch configure you should (unconditionally) patch configure.ac and
call $(RECONF)

However I wonder if it woulnd't be better solved by:
mkdir -p lib
ln -s lib/64 lib/.

Is nettle the only library installing in lib/64 ?

>  	$(MOVE)
>  
>  DEPS_nettle = gmp $(DEPS_gmp)
> 
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel