[vlc-devel] [PATCH 2/3] core: add a new type of callback for list variables
Rémi Denis-Courmont
remi at remlab.net
Thu Jul 24 10:30:01 CEST 2014
Le 2014-07-23 19:56, Felix Abecassis a écrit :
>> I'd rather add a new table. Is there any particular reason for
>> multiplexing
>> the different callback types?
> With an additional type like list_callback_entry_t
Mostly, about not adding an enumeration and not iterating through
entries of the wrong type.
> and a separate
> table for storing these callbacks, I think too much code would have
> to
> be duplicated.
I don't see how it requires more duplication. The trigger code needs
duplication in any case, the add/remove code needs indirection already
in the existing patch.
--
Rémi Denis-Courmont
More information about the vlc-devel
mailing list