[vlc-devel] [PATCH] Always cache the latest album art

[Rafaël Carré]

Hello,

There is no point in caching covers if we ignore what is cached,
and always save over it, so this patch is rejected in its current form.


On 07/23/14 18:45, Marc Aldorasi wrote:
> This fixes the problem described in
> https://forum.videolan.org/viewtopic.php?f=2&t=79717

>From a quick look at this post, I couldn't find a single file to
reproduce the issue,
Can you provide one?

> ---
>  src/playlist/art.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/src/playlist/art.c b/src/playlist/art.c
> index 18a3764..3ee296d 100644
> --- a/src/playlist/art.c
> +++ b/src/playlist/art.c
> @@ -278,17 +278,7 @@ int playlist_SaveArt( vlc_object_t *obj, input_item_t *p_item,
>          return VLC_EGENERIC;
>      }
>  
> -    /* Check if we already dumped it */
> -    struct stat s;
> -    if( !vlc_stat( psz_filename, &s ) )
> -    {
> -        input_item_SetArtURL( p_item, psz_uri );
> -        free( psz_filename );
> -        free( psz_uri );
> -        return VLC_SUCCESS;
> -    }
> -
> -    /* Dump it otherwise */
> +    /* Dump it */
>      FILE *f = vlc_fopen( psz_filename, "wb" );
>      if( f )
>      {
>