[vlc-devel] [PATCH 0/4] OMX: android hardware buffers: Take 3

[Thomas Guillem]

Hi,

Here is my third attempt to enable android hardware buffers on OMX (see my
first mail for more details).

Martin helped me with the integration and gave me lot of hints for the
cleanliness of the code. You can follow the discussion we had on my github
here: https://github.com/tguillem/vlc/commits/iomx-hwbuf-squash

iomx hardware rendering is only activated with a debug settings.

It's tested and working fine on lot of different SoCs: OMAP4, RK30/31, QCOM,
Exynos, Nvidia. But we have an issue with the Nexus S (more detais here https://github.com/tguillem/vlc/commit/731d104c6be2f27419571ea418b17e5dfd23f747#commitcomment-7018542).

You can found the vlc-android commits that enable iomx_hwbuffer build here:
https://github.com/tguillem/vlc-android/commits/iomx-hwbuf-3

I also added iomx support for android jb and kitkat (libiomx-kk, libiomx-jbmr2,
libiomx-jb), but it's deactivated for now as I don't want to break current
behavior and because MediaCodec is just working fine.

You can uncomment "#LIBVLC_LIBS += libiomx-kk libiomx-jbmr2 libiomx-jb" to
enable iomx after android jellybean.

I saw that vlc-android is using vlc-2.2.git, and I guess you don't want to push
my patches in 2.2 branch. So you can't push my vlc-android patches for now since
libiomx will depend on iomx_hwbuffer.c that won't be found on 2.2 branch. Maybe
I can add a define in the vlc-android/Makefile to enable or not iomx_hwbuffer.c
build, what do you think ?

In any cases, my patches on vlc can be pushed without the vlc-android ones, it
won't break the build or anything else (iomx_hwbuffer.c won't be built).

Best regards,
Thomas Guillem (4):
  iomx: implement OMX_UseBuffer
  iomx: add iomx_hwbuffer
  iomx: add android GraphicBuffers functions.
  omxil: add android hw buffers support (zero copy)

 modules/codec/omxil/iomx.cpp        |   56 +++
 modules/codec/omxil/iomx_hwbuffer.c |  230 ++++++++++
 modules/codec/omxil/omxil.c         |  800 ++++++++++++++++++++++++++++++++++-
 modules/codec/omxil/omxil.h         |   33 ++
 modules/codec/omxil/omxil_core.c    |   23 +
 modules/codec/omxil/omxil_core.h    |   14 +
 6 files changed, 1139 insertions(+), 17 deletions(-)
 create mode 100644 modules/codec/omxil/iomx_hwbuffer.c

-- 
1.7.10.4


-- 


This email and any files transmitted with it are confidential and are 
intended solely for the use of the individual or entity to which they are 
addressed. Access to this e-mail by anyone else is unauthorised. If you are 
not the intended recipient, any disclosure, copying, distribution or any 
action taken or omitted to be taken in reliance on it, is prohibited. 
E-mail messages are not necessarily secure. Archos does not accept 
responsibility for any changes made to this message after it was sent.