[vlc-devel] [PATCH] Language support acording to MKV-Spec

[Maximilian Madlung]

Bonjour Rémi,

Good point! I thought about this too. An argument in favour of putting 
it just in the MKV-Demux would be, that it's from their specification 
and not from any other.
On the other hand, there are no ambiguous codes that could be 
interpreted incorrectly by adding this expression to the core code. It 
would simply extend the possibilities for every container and still 
interpret everything else correctly as before. The language codes, 
whether they have 2 or 3 chars, don't contain "-". So the question to be 
asked would be, if you want to exclude other containers from additional 
functionality in case they (even if unlikely) used this kind of language 
code. This is why I wrote it in the core code.
Thanks for your review and your advice.

Best regards,
Max

El 29/07/14 a las #4, Rémi Denis-Courmont escribió:
> Le 2014-07-29 01:38, Maximilian Madlung a écrit :
>> ---
>>  src/input/es_out.c |   42 +++++++++++++++++++++++++++++++++---------
>>  1 file changed, 33 insertions(+), 9 deletions(-)
>>
>> diff --git a/src/input/es_out.c b/src/input/es_out.c
>> index d5ac33b..cbf6ed2 100644
>> --- a/src/input/es_out.c
>> +++ b/src/input/es_out.c
>> @@ -2727,21 +2727,45 @@ static char *LanguageGetName( const char 
>> *psz_code )
>>          return strdup( "" );
>>      }
>>
>> -    if( strlen( psz_code ) == 2 )
>> +    /* Check if the language code consists a "-[...]" and only take
>> the front
>> +       part as language */
>
> I think that belongs in the MKV demux, not the core code.
>