[vlc-devel] [PATCH] src: input/stream: fix buffer underflow by avoiding inconsistent state in error case

Rémi Denis-Courmont remi at remlab.net
Tue Jun 10 22:24:18 CEST 2014

Le mardi 10 juin 2014, 22:12:34 David Fuhrmann a écrit :
> In my opinion, as a start this patch actually makes the reader aware that
> there might be a problem with an unsigned underflow at this place. This is
> currently not easily spottable at all, because of the definition of the
> variable types at different places. Additionally, I also can add some
> comments, if you think its too confusing. And finally, it fixes a bug and
> thus I propose to commit the fix, even if it might not be the absolutely
> best solution.

The sign overflow part, yes. The refill hack, no way.

This is not medicine but engineering. We don't treat symptoms here; we fix 
problems by their root causes.

Rémi Denis-Courmont

More information about the vlc-devel mailing list