[vlc-devel] [PATCH 00/10] Item browsing system
remi at remlab.net
Thu Jun 12 12:29:50 CEST 2014
Le 2014-06-12 18:07, Julien 'Lta' BALLET a écrit :
> On Tue, May 27, 2014 at 2:18 PM, Rémi Denis-Courmont
> <remi at remlab.net > wrote
>> So far, it seems you only want to clean up the directory expansion
>> within the playlist, but not add dynamic updates. For that modest
>> purpose adding a third read callback to access_t (pf_read_item or
>> pf_readdir or something) should be sufficient. This allows replacing
>> the XSPF generator from the directory plugin in a cleaner and more
>> generic fashion. Then there is no problems with storing state (it
>> can stay in the access_t plugin as before). The changes to the core
>> would be much more contained, and I see absolutely no needs to
>> reinvent the input thread.
> Im wondering whether the pf_readdir callback should returns a
> input_item or an input_item_node :
> - If we return a node, we can handle all the recursive nodes in
> directory.c, but well need to peek into the input_thread to get the
> parent input item.
> - If we return a item, it will behave more like the real readdir
> function, and will allow for simpler item streaming between access
Yes, the input item seems better.
>> Your browsable flags would probably still be useful for fine tuning
>> the playlist GUI, but not for the core.
>> Either way, that wont solve dynamic node updates, so I doubt it
>> will be good enough for UPnP.
> On that matter, im still really interested to know what are correct
> implementations for this.
I have nothing very concrete to propose. I would have added a
browse/expand/subscribe callback to SD (and an collapse/unsubscribe one
too), but it seems that SD has its detractors.
More information about the vlc-devel