[vlc-devel] [PATCH] Fix libmod_plugin undefined __imp_ symbols building for win32

[Kj Tsanaktsidis]

On 12 June 2014 20:39, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le 2014-06-12 18:34, Konstantinos Tsanaktsidis a écrit :
>
>  This patch therefore sets libmod_plugin_la_CPPFLAGS to define the
>> MODPLUG_STATIC macro, which causes modplug.h to not define MODPLUG_EXPORT
>> in this way. An alternative option would be to add a patch to contribs
>> to remove this behaviour from modplug.h, but this seems cleaner.
>>
>
> Better add the -D... flag to the modplug pkg-config, I would argue.
>

That would be a much better idea wouldn't it. I've implemented this now,
I'll just make sure that it still works and send another patch. Thank you
for the help :)

KJ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140612/f90c16a9/attachment.html>