[vlc-devel] [PATCH 09/10] Add new directory 'playlist' module whose job is to feed the playlist with the content of pf_readdir enabled access
Rémi Denis-Courmont
remi at remlab.net
Mon Jun 16 20:07:55 CEST 2014
Le 2014-06-17 00:35, Julien 'Lta' BALLET a écrit :
> On Mon, Jun 16, 2014 at 4:44 PM, Rémi Denis-Courmont <remi at remlab.net
> [1]> wrote:
>
>>> +int Import_Dir ( vlc_object_t *p_this)
>>> +{
>>> + demux_t *p_demux = (demux_t *)p_this;
>>> +
>>> + bool b_is_dir = false;
>>> + stream_Control( p_demux->s, STREAM_IS_DIRECTORY, &b_is_dir
>>> );
>>
>> In principles, b_is_dir is undefined on error, so slightly flawed
>> logic.
>
> this call is documented as should not fail, so this should not
> happen.
Except your patch series leaves a number of failure cases, AFAICT.
--
Rémi Denis-Courmont
More information about the vlc-devel
mailing list