[vlc-devel] [vlc-commits] macosx: move video filter control code to the global libvlccore control object since it does not belong in a window controller

[David Fuhrmann]

Am 16.06.2014 um 12:43 schrieb Felix Paul Kühne <git at videolan.org>:

> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Mon Jun 16 12:39:45 2014 +0200| [c16ab7a4f6880bf54acbe47e24610f84064a732d] | committer: Felix Paul Kühne
> 
> macosx: move video filter control code to the global libvlccore control object since it does not belong in a window controller
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c16ab7a4f6880bf54acbe47e24610f84064a732d
> ---
> 
> modules/gui/macosx/CoreInteraction.h |    8 +-
> modules/gui/macosx/CoreInteraction.m |  265 ++++++++++++++++++++-
> modules/gui/macosx/VideoEffects.h    |    5 -
> modules/gui/macosx/VideoEffects.m    |  421 ++++++++--------------------------
> 4 files changed, 359 insertions(+), 340 deletions(-)

Hi,

What about reduplicating the code even more, and switching to vout_EnableFilter function?

With best regards,
David