[vlc-devel] [PATCH 08/10] Removes xspf generation in access/directory.c in favor of new pf_readdir callback

Rémi Denis-Courmont remi at remlab.net
Thu Jun 19 13:37:11 CEST 2014

Le 2014-06-19 17:29, Julien 'Lta' BALLET a écrit :
> The idea here is to move all recursion related features to
> modules/playlist/directory.c so it can be shared accross all browsing
> module (smb, fs, and in the future, ftp, zip, etc.). Afaik, smb, ftp
> and http dont provide any data that would allow us to limit recursion
> like the device/inode couple do for filesystem,

AFAIK, CIFS has inodes where available.

> this leaves the
> filesystem browsing as the exception rather than the rule.

Again I refuse to reintroduce a currently finely fixed bug in the file 
system support just because some other component is broken-by-design or 

> This also
> mean well have to rely on the user to be clever when using this
> recursion feature (sic).

You cannot rely on the user being clever. The default settings (and 
preferably the non-default settings) have to be safe. Previously, the 
default browsing mode was "expand", and infinite recursion was prevented 
by device and inode matching. "none" mode was intrinsically safe. And 
"collapse" mode was not safe but at least it was not the default.

Your patch series effectively enforces the "collapse" mode and removes 
the other two. Then the playlist code will merrily expand all nodes 
recursively at it iterates them. You need to solve this before your 
patch series is merged.

Rémi Denis-Courmont

More information about the vlc-devel mailing list