[vlc-devel] [PATCH 1/6] Add a pf_readdir callback to access_t modules

[Julien 'Lta' BALLET]

>
>
>
> You should explicitly spell that returning "no data yet" is NOT permitted
> *unlike* with pf_block and pf_read. At least, that is what I understood
> from
> the rest of the series. Note that while this is a non-issue for local file
> systems (directory file handles cannot block), it may become one for
> network
> based protocols...
>

I'll document this more precisely. There isn't any actual limitation about
'no data yet'.
I think the desired behavior is :
 - VLC_SUCCESS -> You have to set b_eof to true and fill the node with all
the item in the folder
 - VLC_ENOITEM -> An unrecoverable error has occured, b_error and b_eof has
to be set to true, there isn't any new item in the node.
 - Other VLC_E*** -> Recoverable error (no mem, io error, etc.), you can
call me again and maybe i'll fill the node that time.

> P.S.: now that you pass an input item node instead of returning one, you
need
> to specify what happens to it on error too. Notably, who is responsible
for
> destroying it...

Thanks for noticing this ! I'll fix this right away
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140621/220145d1/attachment.html>