[vlc-devel] [PATCH 5/6] Make access/directory.c a pf_readdir browsing module

[Julien 'Lta' BALLET]

On Sat, Jun 21, 2014 at 11:11 AM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Laurent established the convention of keeping the existing style of
> existing
> files. I don't mind removing the extra whitespace between function
> identifier
> and parenthesis, but the rest is pretty much standard.
>

Any non-respect of this rule from me must be treated as a typo. I usually
try to pay attention to this, but i've rewritten this piece of code so many
times now  so i guess some have slipped through my attention.


> What was the problem? Reordering code for no reasons make it really hard to
> review.
>
>
Please accept all my apologies for this, i've been taking bits and pieces
from the different previous patches and it resulted in that. I'll fix this


>
> >  error:
> > -    closedir (handle);
> > -    free (p_sys);
> > +    closedir( handle );
> > +    if( p_sys != NULL )
>
> Pointless.
>

(facepalm)

> +        //msg_Dbg( p_access, "|||||| psz_full_uri = %s ", psz_full_uri );

>
> ???
>

(double facepalm)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140621/75d410b3/attachment.html>