[vlc-devel] [PATCH 1/3] ffmpeg: enable PIC on Solaris

[Sean McGovern]

OK. Also I will re-submit as I probably should not be forcing cpu= in this patch.

Thanks for review,

Sean McG.

-----Original Message-----
From: Rémi Denis-Courmont <remi at remlab.net>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Tue, 24 Jun 2014 16:35:32 
To: Mailing list for VLC media player developers<vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH 1/3] ffmpeg: enable PIC on Solaris

Le 2014-06-24 09:08, Sean McGovern a écrit :
> ---
>  contrib/src/ffmpeg/rules.mak |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/contrib/src/ffmpeg/rules.mak 
> b/contrib/src/ffmpeg/rules.mak
> index 4ce4682..8633bb8 100644
> --- a/contrib/src/ffmpeg/rules.mak
> +++ b/contrib/src/ffmpeg/rules.mak
> @@ -135,6 +135,10 @@ else # !Windows
>  FFMPEGCONF += --enable-pthreads
>  endif
>
> +ifdef HAVE_SOLARIS
> +FFMPEGCONF += --cpu=core2 --enable-pic
> +endif
> +

Please keep consistent style with other OSes. Otherwise seems fine.

>  # Build
>  PKGS += ffmpeg
>  ifeq ($(call need_pkg,"libavcodec >= 54.25.0 libavformat >= 53.21.0
> libswscale"),)

-- 
Rémi Denis-Courmont
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel