[vlc-devel] [RFC PATCH 12/13] omxil: new way to wait for omxbuffers to be returned

Martin Storsjö martin at martin.st
Sun Jun 29 23:00:45 CEST 2014

On Thu, 26 Jun 2014, Thomas Guillem wrote:

> Add OMX_BUFFER_COUNT_* macro: Increment count when we send a buffer to OMX
> (FillThisBuffer/EmptyThisBuffer). Decrement count on
> FillBufferDone/EmptyBufferDone callback. On FreeBuffers, wait for buffer count
> to be zero.

Why? To me, this just makes the code much more complicated. Is this 
required for patch 13/13 in some way? Is it impossible to implement patch 
13/13 without this?

A commit message should not only explain _what_ you do, but more 
importantly, why (in case that is not obvious, which it is not here).

// Martin

More information about the vlc-devel mailing list