[vlc-devel] [PATCH] filesystem: use a sane default for NAME_MAX

[Sean McGovern]

Hi Rémi,

On Monday, March 10, 2014, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le lundi 10 mars 2014, 11:06:40 Sean McGovern a écrit :
>> ---
>>  src/posix/filesystem.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/posix/filesystem.c b/src/posix/filesystem.c
>> index 326af9e..a1bc646 100644
>> --- a/src/posix/filesystem.c
>> +++ b/src/posix/filesystem.c
>> @@ -29,6 +29,9 @@
>>
>>  #include <stdio.h>
>>  #include <limits.h> /* NAME_MAX */
>> +#ifndef NAME_MAX
>> +# define NAME_MAX 255
>> +#endif
>
> I don't think 255 is very sane, but more importantly, this does not seem
to be
> needed anywhere in that file...
>

My bad -- I forward ported this from my 2.1 tree and I guess never checked
it was still necessary. Is there a process to get this applied to 2.1, or
your patch from January that removes NAME_MAX from vlc_readdir()?

Thanks,

Sean McG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140310/bf5349e4/attachment.html>