[vlc-devel] [vlc-commits] demux: ogg: rewrite pts and pts computation (fix #9828)

Tristan Matthews le.businessman at gmail.com
Tue Mar 11 04:01:22 CET 2014


On Mon, Mar 10, 2014 at 12:11 PM, Francois Cartegnie <git at videolan.org> wrote:
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Fri Feb 28 02:03:15 2014 +0100| [ff681fc79fae79f428df272a9d005efef2fc9c87] | committer: Francois Cartegnie
>
> demux: ogg: rewrite pts and pts computation (fix #9828)
>
> - Previous algorithm was unable to guess the first packet
> pts because of ogg design (some codecs/opus/vorbis have total
> sample at page granule and only granule on last packet. You
> then need to compute first packet pts backward using packets
> duration).
> So we were stuck either assuming a start at pts/pcr zero, or
> be unable to handle ogg streaming (non zero start) correctly,
> or had to always drop the 0..N-1 packets for first page.
> We need libvorbis to correcly compute those durations (code
> is far more complex than opus's one).
> - Refactorized to discard the tons of cases appended
> with each new codec.
> - lots of other fixes in many places

Great work, plays all my samples fine with nothing skipped at the beginning.

Best,
Tristan



More information about the vlc-devel mailing list