[vlc-devel] [PATCH] more caopengllayer vout changes

[Felix Paul Kühne]

Dear Florent,

On 11.03.2014, at 15:16, Florent Pillet <fpillet at gmail.com> wrote:

> Here is a more complete patch to caopengllayer. In particular, it groups two synchronous calls to the main thread into one. Also uses CATransaction lock / unlock when possible instead of being / commit, as the lock / unlock sequence is designed to guarantee data integrity when reading or setting model values in CALayer accross threads.

Very cool!

> Also, the b_frame_available flag is cleared at the right location (just when we are sure that the frame has actually been consumed).

Nice!

> One note about this patch, it uses GCD (so requires Mac OS X 10.6+ / iOS 4+). Since VLC itself requires Mac OS X 10.6 or later, I assumed it was safe to use dispatch_* calls.

Yep, absolutely. Using GCD for this module is an excellent idea. For libvlc 2.1 and later (this module is part of 2.2), we don't support 10.5 anymore to breaking it as absolutely fine. Regarding iOS, we still support 5.1.1 within MobileVLCKit and we intend to keep support for it for some time (the VLC iOS app requires 6.1 though).

Your patch is fine as is if you drop the module name shortcut as pointed in the other thread. As soon as you post an amended version, I'll merge it.

Cheers,

Felix

-- 
VideoLAN
Felix Paul Kühne
Developer of VLC's ports to OS X and iOS
http://www.videolan.org
Blog: http://feepk.net
Twitter: @feepk