[vlc-devel] [PATCH 05/11] Video output: support rotated movies

[Rémi Denis-Courmont]

Le jeudi 6 mars 2014, 01:12:26 Matthias Keiser a écrit :
> ---
>  src/video_output/video_output.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/video_output/video_output.c
> b/src/video_output/video_output.c index 64bef99..a629e9f 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -918,6 +918,7 @@ static int ThreadDisplayRenderPicture(vout_thread_t
> *vout, bool is_forced) vd->info.subpicture_chromas &&
>                             *vd->info.subpicture_chromas != 0;
>      const bool do_early_spu = !do_dr_spu &&
> +                               vd->source.orientation ==
> vd->fmt.orientation && //snapshots will be missing subpictures in this case
> (vd->info.is_slow ||

Please wrap. I'm not sure why this is needed, so maybe this needs a bit more 
text in the commit message.

>                                 sys->display.use_dr ||
>                                 do_snapshot ||
> @@ -964,8 +965,10 @@ static int ThreadDisplayRenderPicture(vout_thread_t
> *vout, bool is_forced) }
>      }
> 
> +    video_format_t fmt_spu_rot;
> +    video_format_ApplyRotation(&fmt_spu, &fmt_spu_rot);
>      subpicture_t *subpic = spu_Render(vout->p->spu,
> -                                      subpicture_chromas, &fmt_spu,
> +                                      subpicture_chromas, &fmt_spu_rot,

Should this not rather be done in spu_Render()? I don't know but there are two 
other call sites for spu_Render().

>                                        &vd->source,
>                                        render_subtitle_date,
> render_osd_date, do_snapshot);

-- 
Rémi Denis-Courmont
http://www.remlab.net/