[vlc-devel] [PATCH 05/11] Video output: support rotated movies

[Rémi Denis-Courmont]

Le mercredi 12 mars 2014, 21:52:11 Matthias Keiser a écrit :
> Am 12.03.2014 um 18:45 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> > Le jeudi 6 mars 2014, 01:12:26 Matthias Keiser a écrit :
> >> ---
> >> src/video_output/video_output.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/src/video_output/video_output.c
> >> b/src/video_output/video_output.c index 64bef99..a629e9f 100644
> >> --- a/src/video_output/video_output.c
> >> +++ b/src/video_output/video_output.c
> >> @@ -918,6 +918,7 @@ static int ThreadDisplayRenderPicture(vout_thread_t
> >> *vout, bool is_forced) vd->info.subpicture_chromas &&
> >> 
> >>                            *vd->info.subpicture_chromas != 0;
> >>     
> >>     const bool do_early_spu = !do_dr_spu &&
> >> 
> >> +                               vd->source.orientation ==
> >> vd->fmt.orientation && //snapshots will be missing subpictures in this
> >> case
> >> (vd->info.is_slow ||
> > 
> > Please wrap. I'm not sure why this is needed, so maybe this needs a bit
> > more text in the commit message.
> 
> Since snapshots are not filtered through the display filter chain, they are
> never rotated. The means subpictures are oriented wrongly (no matter if we
> do or don't  call video_format_ApplyRotation before spu_Render).

I don't really understand how this relates to the snippet.

> I think
> the question is why snapshots are not filtered through the display filter
> chain, after all the user probably wants to make a snapshot of what he
> sees.

I think it's done so that we get a snapshot of the original material in 
original quality, independent of user filters and limitations of the video 
output plugin.

-- 
Rémi Denis-Courmont
http://www.remlab.net/