[vlc-devel] [PATCH 10/11] Make sdl vout module handle rotated movies.

[Rémi Denis-Courmont]

Le jeudi 6 mars 2014, 01:12:31 Matthias Keiser a écrit :
> ---
>  modules/video_output/sdl.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/modules/video_output/sdl.c b/modules/video_output/sdl.c
> index 5520bb2..a93f201 100644
> --- a/modules/video_output/sdl.c
> +++ b/modules/video_output/sdl.c
> @@ -165,6 +165,8 @@ static int Open(vlc_object_t *object)
> 
>      /* */
>      video_format_t fmt = vd->fmt;
> +    video_format_ApplyRotation(&fmt, &vd->fmt);
> +    fmt = vd->fmt;

You could save at least one copy, two copies if ApplyRotation were allowed to 
operate in place. In retrospect, it would have better custom to pass the first 
parameter as the output and second as the input.

-- 
Rémi Denis-Courmont
http://www.remlab.net/