[vlc-devel] [PATCH v2] libvlc: equalizer: Use ISO bands instead of VLC bands

[Rémi Denis-Courmont]

Le lundi 17 mars 2014, 19:37:14 Ronald Wright a écrit :
> This eliminates the inconsistency between the equalizer bands that are
> portrayed by the API and the bands that are actually used by the equalizer
> module.
> ---
>  lib/media_player.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/media_player.c b/lib/media_player.c
> index 7df46f4..ddf12b8 100644
> --- a/lib/media_player.c
> +++ b/lib/media_player.c
> @@ -489,6 +489,7 @@ libvlc_media_player_new( libvlc_instance_t *instance )
> 
>      /* Equalizer */
>      var_Create (mp, "equalizer-preamp", VLC_VAR_FLOAT);
> +    var_Create (mp, "equalizer-vlcfreqs", VLC_VAR_BOOL);
>      var_Create (mp, "equalizer-bands", VLC_VAR_STRING);
> 
>      mp->p_md = NULL;
> @@ -1502,12 +1503,14 @@ int libvlc_media_player_set_equalizer(
> libvlc_media_player_t *p_mi, libvlc_equal }
> 
>      var_SetFloat( p_mi, "equalizer-preamp", f_preamp );
> +    var_SetBool( p_mi, "equalizer-vlcfreqs", false );

Seems like a no-op.

>      var_SetString( p_mi, "equalizer-bands", psz_bands );
> 
>      audio_output_t *p_aout = input_resource_HoldAout(
> p_mi->input.p_resource ); if ( p_aout )
>      {
>          var_SetFloat( p_aout, "equalizer-preamp", f_preamp );
> +        var_SetBool( p_aout, "equalizer-vlcfreqs", false );

Ditto, even more so.

>          var_SetString( p_aout, "equalizer-bands", psz_bands );
> 
>          vlc_object_release( p_aout );

-- 
Rémi Denis-Courmont
http://www.remlab.net/