[vlc-devel] [PATCH] access/http: set metadata update flag when metadata changed (close #9332)

[Rémi Denis-Courmont]

Le dimanche 23 mars 2014, 14:19:38 Felix Paul Kühne a écrit :
> ---
>  modules/access/http.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/modules/access/http.c b/modules/access/http.c
> index 3908fb7..caa4d11 100644
> --- a/modules/access/http.c
> +++ b/modules/access/http.c
> @@ -36,6 +36,7 @@
> 
> 
>  #include <vlc_access.h>
> +#include <vlc_demux.h> // for INPUT_UPDATE_META
> 
>  #include <vlc_dialog.h>
>  #include <vlc_meta.h>
> @@ -871,7 +872,7 @@ static int ReadICYMeta( access_t *p_access )
>              p_sys->psz_icy_title = EnsureUTF8( psz_tmp );
>              if( !p_sys->psz_icy_title )
>                  free( psz_tmp );
> -            //p_access->info.i_update |= INPUT_UPDATE_META; FIXME
> +            p_access->info.i_update |= INPUT_UPDATE_META;

That's utterly pointless given that none of the potential callers read the 
field, and particularly not the stream_t buffer instance in the case of the 
input thread.

-- 
Rémi Denis-Courmont
http://www.remlab.net/