[vlc-devel] [PATCH 1/2] src/input: add metadata feedback mechanism for access modules (refs #9332)

Felix Paul Kühne fkuehne at videolan.org
Sun Mar 23 15:05:53 CET 2014


Hello,

On 23.03.2014, at 14:41, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le dimanche 23 mars 2014, 14:20:36 Felix Paul Kühne a écrit :
>> @@ -2304,9 +2323,9 @@ static int InputSourceInit( input_thread_t *p_input,
>>     }
>>     else
>>     {   /* Now try a real access */
>> -        access_t *p_access = access_New( p_input, p_input,
>> -                                         psz_access, psz_demux, psz_path );
>> -        if( p_access == NULL )
>> +        in->p_access = access_New( p_input, p_input,
>> +                                   psz_access, psz_demux, psz_path );
>> +        if( in->p_access == NULL )
> 
> This is not safe. The commit logs and bugs tracker already explain the details 
> at length.

Ok, I'll try to recover this info and come back to you as needed.

Thanks,

Felix




More information about the vlc-devel mailing list