[vlc-devel] [vlc-commits] macosx: do not explicitely set presentation options for native fullscreen mode

[David Fuhrmann]

Am 31.03.2014 um 20:33 schrieb Felix Paul Kühne <fkuehne at videolan.org>:

> Hey David,
> 
> On 31.03.2014, at 20:29, David Fuhrmann <git at videolan.org> wrote:
> 
>> vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Mon Mar 31 20:20:46 2014 +0200| [67004e36c5b3d9aaef68b2febcbe1df531829fe9] | committer: David Fuhrmann
>> 
>> macosx: do not explicitely set presentation options for native fullscreen mode
>> 
>> These flags will be set internally to the correct values. Mavericks even
>> warns in the log that these calls are ignored. Additionally, the os itself
>> knows best if the dock needs to be hidden - this is not always the case due
>> to the new multi-monitor fullscreen in Mavericks.
> 
> Are you sure that this isn't a very bad idea? What happens on previous OS X version, especially when using the non-native fullscreen mode?

Hi Felix,

This commit only modifies code paths for the native mode. For non-native mode, auto hide dock and menu is already done at another place (and in a more clever way).
I tested it on 10.9 and 10.8, so I assume that it will also work right on 10.7.

With best regards,
David