[vlc-devel] [PATCH 7/7] config: simplify keycmp

[Rémi Denis-Courmont]

Le mardi 6 mai 2014, 22:37:44 Felix Abecassis a écrit :
> Do we really need speed here?
> 
> It avoids an conversion to int after an unsigned overflow.

I believe we depend on the reasonable/GCC modulo behaviour in many paths.
Sometimes it is even more or less enforced by the underlying libraries. For 
instance, iconv() returns (size_t)-1 on error.

So even though I cannot find any such warranty in POSIX, I think we should 
continue to rely on the GCC behaviour for lack of any reasonable alternative.

-- 
Rémi Denis-Courmont
http://www.remlab.net/