[vlc-devel] [PATCH 2/7] vdpau: fix redundant const qualifier

[Felix Abecassis]

Having the pointer const is arguable indeed, but I don't see how the
const is redundant here.

2014-05-06 22:11 GMT+02:00 Rémi Denis-Courmont <remi at remlab.net>:
> Le mardi 6 mai 2014, 19:08:26 Felix Abecassis a écrit :
>> Was meant as constant pointer and constant pointed data.
>> ---
>>  modules/hw/vdpau/vlc_vdpau.c | 4 ++--
>>  modules/hw/vdpau/vlc_vdpau.h | 4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/modules/hw/vdpau/vlc_vdpau.c b/modules/hw/vdpau/vlc_vdpau.c
>> index 8e0a76d..9b44be8 100644
>> --- a/modules/hw/vdpau/vlc_vdpau.c
>> +++ b/modules/hw/vdpau/vlc_vdpau.c
>> @@ -321,7 +321,7 @@ VdpStatus vdp_output_surface_render_output_surface(const
>> vdp_t *vdp, VdpOutputSurface dst_surface, const VdpRect *dst_rect,
>>      VdpOutputSurface src_surface, const VdpRect *src_rect,
>>      const VdpColor *colors,
>> -    const VdpOutputSurfaceRenderBlendState const *state, uint32_t flags)
>> +    const VdpOutputSurfaceRenderBlendState *const state, uint32_t flags)
>>  {
>>      return vdp->vt.output_surface_render_output_surface(dst_surface,
>> dst_rect, src_surface, src_rect, colors, state, flags);
>> @@ -422,7 +422,7 @@ VdpStatus vdp_video_mixer_set_feature_enables(const
>> vdp_t *vdp,
>>
>>  VdpStatus vdp_video_mixer_set_attribute_values(const vdp_t *vdp,
>>      VdpVideoMixer mixer, uint32_t count,
>> -    const VdpVideoMixerAttribute const *ids, const void *const *values)
>> +    const VdpVideoMixerAttribute *const ids, const void *const *values)
>
> Isn't that replacing a redundant const with another redundant const??
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



-- 
Félix Abecassis
http://felix.abecassis.me