[vlc-devel] [PATCH 7/7] config: simplify keycmp

[Rémi Denis-Courmont]

Le 2014-05-07 12:08, Felix Abecassis a écrit :
>> Then take RTP as an example that definitely does it the "wrong" way. 
>> I would
>> also suspect some sanity checks do this, but only happen in corner 
>> cases.
> I'm not sure what you mean here, I found one use 0xffffffff but with
> uint32_t so it seemed fine.

RTP casts a larger integer to int16_t; that relies on the GCC non-ISO 
semantics. That is just one example on top of my head.

Also AFAIU, downcasting signed to signed suffers the same problem, not 
just unsigned to signed.

-- 
Rémi Denis-Courmont