[vlc-devel] [PATCH] Avoid deadlock on stop() using UDP on Android

Rémi Denis-Courmont remi at remlab.net
Sun May 11 03:37:39 CEST 2014

Le 2014-05-09 18:58, Romain Vimont a écrit :
> Android has no pthread_cancel(). Its behavior is emulated in
> vlc_cancel() using a flag "killed", but it can lead to unavoidable 
> race
> conditions, typically between a call to vlc_object_alive() and a
> blocking cond_wait().

I don't see that. But if there is a bug in the Android port, fix the 
Android port.

I refuse to hack the UDP access unless there is a bug in the UDP 
access. If there is a bug in the UDP access, then it needs to be 
described correctly, and there is no need to touch the FIFO code.

Either way, this patch looks wrong.

Rémi Denis-Courmont

More information about the vlc-devel mailing list