[vlc-devel] [PATCH 2/3] src/input: add a new input option flag to replace values of existing options

[David Fuhrmann]

Am 11.05.2014 um 12:00 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> Le 2014-05-11 17:45, David Fuhrmann a écrit :
> 
>> UNIQUE and REPLACE are mutually exclusive. I will add this to the
>> documentation. If someone still passes both flags, it looks fine that
>> UNIQUE as the the „stronger“ variant take precedence.
> 
> The whole proposal does not make much sense. I believe there cannot functionally be two options with the same name in a single input item (unlike in stream output chain) - only one will take effect.

Hi,

Exactly. Only the last one will take effect. For instance, if you add several start-time=xy options, the last one will be used.

This might be fine with a temporary playlist, but the main reason for this patch is that these options are also saved in the media library for the respective items. As we want to implement a resume playback feature, it is a bad idea to collect more and more start-time options over the time, which will all outlive VLC restarts. In result, you would end up with a really blown up media library file.

We might replace the options as I proposed. Another way might be to provide a way to delete existing options, but this would be more invasive (for identifying/parsing existing options and so on), so I would not favor this for now.

With best regards,
David