[vlc-devel] [PATCH 10/10] video_filter/swscale.c: The mapping for VLC_CODEC_ARGB into PIX_FMT_BGR32_1 is wrong.

[jpsaman at videolan.org]

From: Jean-Paul Saman <jpsaman at videolan.org>

Mapping VLC_CODEC_ARGB to PIX_FMT_BGR32_1 maps plane R -> B and B -> R. This makes the colors totally wrong. I believe the correct PIX_FMT mapping should be PIX_FMT_RGB32. Then R -> R, G -> G and B -> B.

Conflicts:
	modules/video_chroma/swscale.c
---
 modules/video_chroma/swscale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/swscale.c
index 6559078..ea3318e 100644
--- a/modules/video_chroma/swscale.c
+++ b/modules/video_chroma/swscale.c
@@ -271,7 +271,7 @@ static void FixParameters( int *pi_fmt, bool *pb_has_a, bool *pb_swap_uv, vlc_fo
         *pb_has_a = true;
         break;
     case VLC_CODEC_ARGB:
-        *pi_fmt = PIX_FMT_BGR32_1;
+        *pi_fmt = PIX_FMT_RGB32;
         *pb_has_a = true;
         break;
     case VLC_CODEC_YV12:
-- 
1.9.0