[vlc-devel] [PATCH] demux: avcodec: audio: reset reference time on backward seek (fix #9176)

Ilkka Ollakka ileoo at videolan.org
Fri May 16 09:43:27 CEST 2014

On Thu, May 15, 2014 at 08:25:00PM +0200, Francois Cartegnie wrote:
> Le 01/05/2014 12:26, Rémi Denis-Courmont a écrit :

> >> +            date_Get(
> >> &p_sys->end_date ) - p_block->i_pts > AOUT_MAX_PREPARE_TIME
> >> +      ) )

> > No please. MAX_PREPARE_TIME is only for use by audio outputs (to size play-out 
> > buffers) and the core (to detect overflow). This really does not belong in 
> > decoders.

> I have no real way to guess if there's a discontinuity, as some blocks
> might not have duration.

> Matching the AOUT_MAX_PREPARE_TIME limit is better than picking an
> arbitrary value.

Maybe it would be better just define new constant that for now has same
value than AOUT_MAX_PREPARE_TIME, so in future it doesn't give any hint
that PREPARE_TIME would relate directly on decoding?

Ilkka Ollakka
"It is hard to overstate the debt that we owe to men and women of genius."
		-- Robert G. Ingersoll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140516/48a08795/attachment.sig>

More information about the vlc-devel mailing list