[vlc-devel] [PATCH] lib: fix position enumeration values

[Mark Lee]

Hi,

On 20 May 2014 13:13, Jean-Baptiste Kempf <jb at videolan.org> wrote:

> On 20 May, Mark Lee wrote :
> > ---
> >  include/vlc/libvlc_media_player.h | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
>
> Sorry, but what is it fixing?
>

This enumeration is used by the
libvlc_media_player_set_video_title_display() function. This API function
sets the value of the "video-title-position" variable which is used later
to create an SPU to display for the title.

When the vout OSD function is eventually called to display the video title,
it expects the value of this variable to be a bitwise OR of constants
declared in "include/vlc_subpicture.h".

/* Subpicture region position flags */
#define SUBPICTURE_ALIGN_LEFT 0x1
#define SUBPICTURE_ALIGN_RIGHT 0x2
#define SUBPICTURE_ALIGN_TOP 0x4
#define SUBPICTURE_ALIGN_BOTTOM 0x8

So it expects top left is 4+1, bottom right is 8+2 and so on.

The values of the enumeration as declared were wrong, so asking e.g. for
the title at the bottom would put the title at the top right, as spotted
here: https://forum.videolan.org/viewtopic.php?f=32&t=119402.

I was unsure whether I should have used these constants to define the
LibVLC position enumeration values or not - but in any event, the
enumerated values as of now will not give the desired result and this patch
sets the correct values.


>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Mark Lee
mark.lee 'at' c <http://mark-lee.com>apricasoftware.co.uk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140520/2588435b/attachment.html>