[vlc-devel] [PATCH] lib: fix position enumeration values

[Rémi Denis-Courmont]

Le 2014-05-20 18:42, Mark Lee a écrit :
> diff --git a/include/vlc/libvlc_media_player.h
> b/include/vlc/libvlc_media_player.h
> index 291343a..ce13a44 100644
> --- a/include/vlc/libvlc_media_player.h
> +++ b/include/vlc/libvlc_media_player.h
> @@ -124,16 +124,16 @@ typedef enum libvlc_navigate_mode_t
>   * Enumeration of values used to set position (e.g. of video title).
>   */
>  typedef enum libvlc_position_t {
> -    libvlc_position_disable=-1,
> -    libvlc_position_center,
> -    libvlc_position_left,
> -    libvlc_position_right,
> -    libvlc_position_top,
> -    libvlc_position_top_left,
> -    libvlc_position_top_right,
> -    libvlc_position_bottom,
> -    libvlc_position_bottom_left,
> -    libvlc_position_bottom_right
> +    libvlc_position_disable      = -1,
> +    libvlc_position_center       =  0,
> +    libvlc_position_left         =  1,
> +    libvlc_position_right        =  2,
> +    libvlc_position_top          =  4,
> +    libvlc_position_top_left     =  5,
> +    libvlc_position_top_right    =  6,
> +    libvlc_position_bottom       =  8,
> +    libvlc_position_bottom_left  =  9,
> +    libvlc_position_bottom_right = 10
>  } libvlc_position_t;

For bit masks, hexadecimal or octal numbers are preferred.

-- 
Rémi Denis-Courmont