[vlc-devel] [PATCH] hotkeys: new hotkey for toggling subtitles

A. Haensler a.hae at gmx.de
Wed May 21 05:34:55 CEST 2014

> Why do you store the index instead of the unique ID? The index will be
> shifted if the set of subtitle tracks changes.

You are right. I have sent changes.

> Please, no unchecked raw var_Get() and var_Set() in new code, unless
> you really need to.

I changed it to var_GetInteger() and var_SetInteger(). Old code still has var_Get().

More information about the vlc-devel mailing list